Skip to content

Fix/AxeCraftLogSwap #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: Development
Choose a base branch
from
Open

Fix/AxeCraftLogSwap #557

wants to merge 5 commits into from

Conversation

illyrius666
Copy link
Contributor

added missing cherry and pale oak entries into AxeCraftLogSwap recipies

@illyrius666
Copy link
Contributor Author

illyrius666 commented Jun 19, 2025 •
edited
Loading

@CrazyDev05 i added some TODOs which i would like for you to check. they contain some questions about Material.PALE_OAK_*

@illyrius666 illyrius666 marked this pull request as draft June 19, 2025 06:26
@CrazyDev05
Copy link
Contributor

@illyrius666 check this class https://github.com/VolmitSoftware/Adapt/blob/main/src/main/java/com/volmit/adapt/util/reflect/registries/Materials.java
be aware that materials that are missing on the version are null

@illyrius666
Copy link
Contributor Author

@illyrius666 check this class https://github.com/VolmitSoftware/Adapt/blob/main/src/main/java/com/volmit/adapt/util/reflect/registries/Materials.java be aware that materials that are missing on the version are null

i will use that class instead of using Material directly
and i will add some checks based on if available on that mc version

@CrazyDev05
Copy link
Contributor

@illyrius666 ye just wrap the register method for the recipe in a null check

@illyrius666
made use of internal Materials utils for pale oak. replaced cherry fr…
7e24a1f 
…om Material to Materials. added null checks for cherry & pale oak for when playing on a mc version that doesnt have them to prevent nullpointerexception.
@CrazyDev05 CrazyDev05 marked this pull request as ready for review June 19, 2025 10:32
@illyrius666 illyrius666 marked this pull request as draft June 19, 2025 10:34
@illyrius666 illyrius666 marked this pull request as ready for review June 19, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@illyrius666 @CrazyDev05