note that fragment directive is percent encoded using the standard percent encoded set #197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rcent encoded set
|
This is concerning #194. |
|
I think I fixed the check, I got an account at the W3C: https://www.w3.org/users/139600 |
|
It's also showing me as linked: |
|
I sent an email to yoav to get this check cleared. (Hoping they can help). |
|
zamicol marked as non substantive for IPR from ash-nazg. |
bokand
approved these changes
Aug 29, 2022
| set](https://url.spec.whatwg.org/#fragment-percent-encode-set) must be percent | ||
| encoded. | ||
| encoded. Fragment directive requires the more restrictive [percent encode | ||
| set](https://url.spec.whatwg.org/#percent-encoded-bytes). |
There was a problem hiding this comment.
This refers to a "set" but links to instructions on how to percent encode/decode. Should we link instead to the scroll-to-text-fragment spec instead?
ghost
approved these changes
Sep 3, 2022
ghost
approved these changes
Sep 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.