Skip to content

Conversation

nicoonswift
Copy link
Contributor

Hello,

Similar to #221, please find both ES and LATAM spanish string files.

@nicoonswift
Copy link
Contributor Author

Hello, I see there’s a CI check failing. I don’t know if the CI build gets triggered on PR creation or if any other action is required to do so.

@ghost
Copy link

ghost commented Mar 9, 2020

Messages
📖

View more details on Bitrise

📖 WeScan: Executed 56 tests, with 0 failures (0 unexpected) in 21.045 (21.110) seconds

Generated by 🚫 Danger Swift against 8ae5374

Copy link
Contributor

@Boris-Em Boris-Em left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

Copy link
Contributor

@AvdLee AvdLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, I see there’s a CI check failing. I don’t know if the CI build gets triggered on PR creation or if any other action is required to do so.

It's because we manually need to approve running builds for incoming PRs. It's succeeding now and your contribution looks good. Thanks!

@AvdLee AvdLee merged commit d4bd6b0 into WeTransfer:master Mar 10, 2020
@ghost
Copy link

ghost commented Mar 11, 2020

Congratulations! 🎉 This was released as part of Release 1.5.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants