Skip to content

Trivial change in the description: Clarify "type" is $pr_type in $prestat_u::dir and $prestat_dir #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
igrep opened this issue Feb 6, 2020 · 1 comment · Fixed by #222

Comments

@igrep
Copy link
Contributor

igrep commented Feb 6, 2020

Let me file an issue beforehand to make it sure (I've already joined in the Community Group. So I'm ready to send a PR if okay).

I suggest the word "type" in the descriptions of $prestat_u::dir and $prestat_dir should be clarified as $pr_type.
We can actually easily infer from the context, but I felt confused a little at first.

@pchickey
Copy link
Contributor

pchickey commented Feb 6, 2020

Thanks. We welcome all PRs that make the docs clearer. That particular text is going away with #220, but I'm happy to accept a PR in the meantime.

igrep added a commit to igrep/WASI that referenced this issue Feb 6, 2020
The word "type" in the descriptions of `$prestat_u::dir` and `$prestat_dir` should be clarified as `$pr_type`.
We can actually easily infer from the context, but I felt confused a little at first.

Fix: WebAssembly#221
igrep added a commit to igrep/WASI that referenced this issue Feb 6, 2020
The word "type" in the descriptions of `$prestat_u::dir` and `$prestat_dir` should be clarified as `$pr_type`.
We can actually easily infer from the context, but I felt confused a little at first.

Fix: WebAssembly#221
sunfishcode pushed a commit that referenced this issue Feb 6, 2020
* Clarify "type" is $pr_type in $prestat_u::dir and $prestat_dir

The word "type" in the descriptions of `$prestat_u::dir` and `$prestat_dir` should be clarified as `$pr_type`.
We can actually easily infer from the context, but I felt confused a little at first.

Fix: #221

* Fix: avoid test failure

underscores in markdown should be escaped, but currently the witx tool doesn't support escaping
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants