Skip to content

reintroduce witx::phases (partial revert #398) #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 22, 2021

Conversation

cratelyn
Copy link

Per this discussion from #434:

It looks like the crate was last published at
7ec4b1a
(diff from
main
),
and if we'd like to make an 0.9.1 release (ideally just a bugfix
release), I think there's another breaking change we merged in the
meantime, notably the deletion of tools/witx/src/phases.rs, which I
think happened as #398. I think we may need to revert that as well
before publishing 0.9.1?

-- @alexcrichton

This reintroduces 'witx::phases', so that we do not include any breaking
changes in what ought to be a pure bug release.

Per this discussion from WebAssembly#434:

> It looks like the crate was last published at
> [7ec4b1a](WebAssembly@7ec4b1a)
> ([diff from
> `main`](WebAssembly/WASI@ef8c1a5...main)),
> and if we'd like to make an 0.9.1 release (ideally just a bugfix
> release), I think there's another breaking change we merged in the
> meantime, notably the deletion of `tools/witx/src/phases.rs`, which I
> think happened as WebAssembly#398. I think we may need to revert that as well
> before publishing 0.9.1?

    - [@alexcrichton](WebAssembly#434 (comment))

This reintroduces 'witx::phases', so that we do not include any breaking
changes in what ought to be a pure bug release.
@alexcrichton alexcrichton merged commit 03a7d9c into WebAssembly:main Jun 22, 2021
@cratelyn cratelyn deleted the katie/its-not-a-phase-mom branch June 22, 2021 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants