Skip to content

Commit 28e88b9

Browse files
authored
[EH] Replace event with tag (#3937)
We recently decided to change 'event' to 'tag', and to 'event section' to 'tag section', out of the rationale that the section contains a generalized tag that references a type, which may be used for something other than exceptions, and the name 'event' can be confusing in the web context. See - WebAssembly/exception-handling#159 (comment) - WebAssembly/exception-handling#161
1 parent 97e277c commit 28e88b9

File tree

106 files changed

+894
-909
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

106 files changed

+894
-909
lines changed

src/binaryen-c.cpp

Lines changed: 79 additions & 79 deletions
Original file line numberDiff line numberDiff line change
@@ -201,8 +201,8 @@ BinaryenExternalKind BinaryenExternalMemory(void) {
201201
BinaryenExternalKind BinaryenExternalGlobal(void) {
202202
return static_cast<BinaryenExternalKind>(ExternalKind::Global);
203203
}
204-
BinaryenExternalKind BinaryenExternalEvent(void) {
205-
return static_cast<BinaryenExternalKind>(ExternalKind::Event);
204+
BinaryenExternalKind BinaryenExternalTag(void) {
205+
return static_cast<BinaryenExternalKind>(ExternalKind::Tag);
206206
}
207207

208208
// Features
@@ -1287,8 +1287,8 @@ BinaryenExpressionRef BinaryenRefEq(BinaryenModuleRef module,
12871287
BinaryenExpressionRef BinaryenTry(BinaryenModuleRef module,
12881288
const char* name,
12891289
BinaryenExpressionRef body,
1290-
const char** catchEvents,
1291-
BinaryenIndex numCatchEvents,
1290+
const char** catchTags,
1291+
BinaryenIndex numCatchTags,
12921292
BinaryenExpressionRef* catchBodies,
12931293
BinaryenIndex numCatchBodies,
12941294
const char* delegateTarget) {
@@ -1297,8 +1297,8 @@ BinaryenExpressionRef BinaryenTry(BinaryenModuleRef module,
12971297
ret->name = name;
12981298
}
12991299
ret->body = (Expression*)body;
1300-
for (BinaryenIndex i = 0; i < numCatchEvents; i++) {
1301-
ret->catchEvents.push_back(catchEvents[i]);
1300+
for (BinaryenIndex i = 0; i < numCatchTags; i++) {
1301+
ret->catchTags.push_back(catchTags[i]);
13021302
}
13031303
for (BinaryenIndex i = 0; i < numCatchBodies; i++) {
13041304
ret->catchBodies.push_back((Expression*)catchBodies[i]);
@@ -1311,15 +1311,15 @@ BinaryenExpressionRef BinaryenTry(BinaryenModuleRef module,
13111311
}
13121312

13131313
BinaryenExpressionRef BinaryenThrow(BinaryenModuleRef module,
1314-
const char* event,
1314+
const char* tag,
13151315
BinaryenExpressionRef* operands,
13161316
BinaryenIndex numOperands) {
13171317
std::vector<Expression*> args;
13181318
for (BinaryenIndex i = 0; i < numOperands; i++) {
13191319
args.push_back((Expression*)operands[i]);
13201320
}
13211321
return static_cast<Expression*>(
1322-
Builder(*(Module*)module).makeThrow(event, args));
1322+
Builder(*(Module*)module).makeThrow(tag, args));
13231323
}
13241324

13251325
BinaryenExpressionRef BinaryenRethrow(BinaryenModuleRef module,
@@ -2979,55 +2979,55 @@ void BinaryenTrySetBody(BinaryenExpressionRef expr,
29792979
assert(bodyExpr);
29802980
static_cast<Try*>(expression)->body = (Expression*)bodyExpr;
29812981
}
2982-
BinaryenIndex BinaryenTryGetNumCatchEvents(BinaryenExpressionRef expr) {
2982+
BinaryenIndex BinaryenTryGetNumCatchTags(BinaryenExpressionRef expr) {
29832983
auto* expression = (Expression*)expr;
29842984
assert(expression->is<Try>());
2985-
return static_cast<Try*>(expression)->catchEvents.size();
2985+
return static_cast<Try*>(expression)->catchTags.size();
29862986
}
29872987
BinaryenIndex BinaryenTryGetNumCatchBodies(BinaryenExpressionRef expr) {
29882988
auto* expression = (Expression*)expr;
29892989
assert(expression->is<Try>());
29902990
return static_cast<Try*>(expression)->catchBodies.size();
29912991
}
2992-
const char* BinaryenTryGetCatchEventAt(BinaryenExpressionRef expr,
2993-
BinaryenIndex index) {
2992+
const char* BinaryenTryGetCatchTagAt(BinaryenExpressionRef expr,
2993+
BinaryenIndex index) {
29942994
auto* expression = (Expression*)expr;
29952995
assert(expression->is<Try>());
2996-
assert(index < static_cast<Try*>(expression)->catchEvents.size());
2997-
return static_cast<Try*>(expression)->catchEvents[index].c_str();
2996+
assert(index < static_cast<Try*>(expression)->catchTags.size());
2997+
return static_cast<Try*>(expression)->catchTags[index].c_str();
29982998
}
2999-
void BinaryenTrySetCatchEventAt(BinaryenExpressionRef expr,
3000-
BinaryenIndex index,
3001-
const char* catchEvent) {
2999+
void BinaryenTrySetCatchTagAt(BinaryenExpressionRef expr,
3000+
BinaryenIndex index,
3001+
const char* catchTag) {
30023002
auto* expression = (Expression*)expr;
30033003
assert(expression->is<Try>());
3004-
assert(index < static_cast<Try*>(expression)->catchEvents.size());
3005-
assert(catchEvent);
3006-
static_cast<Try*>(expression)->catchEvents[index] = catchEvent;
3004+
assert(index < static_cast<Try*>(expression)->catchTags.size());
3005+
assert(catchTag);
3006+
static_cast<Try*>(expression)->catchTags[index] = catchTag;
30073007
}
3008-
BinaryenIndex BinaryenTryAppendCatchEvent(BinaryenExpressionRef expr,
3009-
const char* catchEvent) {
3008+
BinaryenIndex BinaryenTryAppendCatchTag(BinaryenExpressionRef expr,
3009+
const char* catchTag) {
30103010
auto* expression = (Expression*)expr;
30113011
assert(expression->is<Try>());
3012-
assert(catchEvent);
3013-
auto& list = static_cast<Try*>(expression)->catchEvents;
3012+
assert(catchTag);
3013+
auto& list = static_cast<Try*>(expression)->catchTags;
30143014
auto index = list.size();
3015-
list.push_back(catchEvent);
3015+
list.push_back(catchTag);
30163016
return index;
30173017
}
3018-
void BinaryenTryInsertCatchEventAt(BinaryenExpressionRef expr,
3019-
BinaryenIndex index,
3020-
const char* catchEvent) {
3018+
void BinaryenTryInsertCatchTagAt(BinaryenExpressionRef expr,
3019+
BinaryenIndex index,
3020+
const char* catchTag) {
30213021
auto* expression = (Expression*)expr;
30223022
assert(expression->is<Try>());
3023-
assert(catchEvent);
3024-
static_cast<Try*>(expression)->catchEvents.insertAt(index, catchEvent);
3023+
assert(catchTag);
3024+
static_cast<Try*>(expression)->catchTags.insertAt(index, catchTag);
30253025
}
3026-
const char* BinaryenTryRemoveCatchEventAt(BinaryenExpressionRef expr,
3027-
BinaryenIndex index) {
3026+
const char* BinaryenTryRemoveCatchTagAt(BinaryenExpressionRef expr,
3027+
BinaryenIndex index) {
30283028
auto* expression = (Expression*)expr;
30293029
assert(expression->is<Try>());
3030-
return static_cast<Try*>(expression)->catchEvents.removeAt(index).c_str();
3030+
return static_cast<Try*>(expression)->catchTags.removeAt(index).c_str();
30313031
}
30323032
BinaryenExpressionRef BinaryenTryGetCatchBodyAt(BinaryenExpressionRef expr,
30333033
BinaryenIndex index) {
@@ -3092,15 +3092,15 @@ bool BinaryenTryIsDelegate(BinaryenExpressionRef expr) {
30923092
return static_cast<Try*>(expression)->isDelegate();
30933093
}
30943094
// Throw
3095-
const char* BinaryenThrowGetEvent(BinaryenExpressionRef expr) {
3095+
const char* BinaryenThrowGetTag(BinaryenExpressionRef expr) {
30963096
auto* expression = (Expression*)expr;
30973097
assert(expression->is<Throw>());
3098-
return static_cast<Throw*>(expression)->event.c_str();
3098+
return static_cast<Throw*>(expression)->tag.c_str();
30993099
}
3100-
void BinaryenThrowSetEvent(BinaryenExpressionRef expr, const char* eventName) {
3100+
void BinaryenThrowSetTag(BinaryenExpressionRef expr, const char* tagName) {
31013101
auto* expression = (Expression*)expr;
31023102
assert(expression->is<Throw>());
3103-
static_cast<Throw*>(expression)->event = eventName;
3103+
static_cast<Throw*>(expression)->tag = tagName;
31043104
}
31053105
BinaryenIndex BinaryenThrowGetNumOperands(BinaryenExpressionRef expr) {
31063106
auto* expression = (Expression*)expr;
@@ -3348,26 +3348,26 @@ BinaryenGlobalRef BinaryenGetGlobalByIndex(BinaryenModuleRef module,
33483348
return globals[index].get();
33493349
}
33503350

3351-
// Events
3351+
// Tags
33523352

3353-
BinaryenEventRef BinaryenAddEvent(BinaryenModuleRef module,
3354-
const char* name,
3355-
uint32_t attribute,
3356-
BinaryenType params,
3357-
BinaryenType results) {
3358-
auto* ret = new Event();
3353+
BinaryenTagRef BinaryenAddTag(BinaryenModuleRef module,
3354+
const char* name,
3355+
uint32_t attribute,
3356+
BinaryenType params,
3357+
BinaryenType results) {
3358+
auto* ret = new Tag();
33593359
ret->setExplicitName(name);
33603360
ret->attribute = attribute;
33613361
ret->sig = Signature(Type(params), Type(results));
3362-
((Module*)module)->addEvent(ret);
3362+
((Module*)module)->addTag(ret);
33633363
return ret;
33643364
}
33653365

3366-
BinaryenEventRef BinaryenGetEvent(BinaryenModuleRef module, const char* name) {
3367-
return ((Module*)module)->getEventOrNull(name);
3366+
BinaryenTagRef BinaryenGetTag(BinaryenModuleRef module, const char* name) {
3367+
return ((Module*)module)->getTagOrNull(name);
33683368
}
3369-
void BinaryenRemoveEvent(BinaryenModuleRef module, const char* name) {
3370-
((Module*)module)->removeEvent(name);
3369+
void BinaryenRemoveTag(BinaryenModuleRef module, const char* name) {
3370+
((Module*)module)->removeTag(name);
33713371
}
33723372

33733373
// Imports
@@ -3419,19 +3419,19 @@ void BinaryenAddGlobalImport(BinaryenModuleRef module,
34193419
ret->mutable_ = mutable_;
34203420
((Module*)module)->addGlobal(ret);
34213421
}
3422-
void BinaryenAddEventImport(BinaryenModuleRef module,
3423-
const char* internalName,
3424-
const char* externalModuleName,
3425-
const char* externalBaseName,
3426-
uint32_t attribute,
3427-
BinaryenType params,
3428-
BinaryenType results) {
3429-
auto* ret = new Event();
3422+
void BinaryenAddTagImport(BinaryenModuleRef module,
3423+
const char* internalName,
3424+
const char* externalModuleName,
3425+
const char* externalBaseName,
3426+
uint32_t attribute,
3427+
BinaryenType params,
3428+
BinaryenType results) {
3429+
auto* ret = new Tag();
34303430
ret->name = internalName;
34313431
ret->module = externalModuleName;
34323432
ret->base = externalBaseName;
34333433
ret->sig = Signature(Type(params), Type(results));
3434-
((Module*)module)->addEvent(ret);
3434+
((Module*)module)->addTag(ret);
34353435
}
34363436

34373437
// Exports
@@ -3481,13 +3481,13 @@ BinaryenExportRef BinaryenAddGlobalExport(BinaryenModuleRef module,
34813481
((Module*)module)->addExport(ret);
34823482
return ret;
34833483
}
3484-
BinaryenExportRef BinaryenAddEventExport(BinaryenModuleRef module,
3485-
const char* internalName,
3486-
const char* externalName) {
3484+
BinaryenExportRef BinaryenAddTagExport(BinaryenModuleRef module,
3485+
const char* internalName,
3486+
const char* externalName) {
34873487
auto* ret = new Export();
34883488
ret->value = internalName;
34893489
ret->name = externalName;
3490-
ret->kind = ExternalKind::Event;
3490+
ret->kind = ExternalKind::Tag;
34913491
((Module*)module)->addExport(ret);
34923492
return ret;
34933493
}
@@ -4146,21 +4146,21 @@ BinaryenExpressionRef BinaryenGlobalGetInitExpr(BinaryenGlobalRef global) {
41464146
}
41474147

41484148
//
4149-
// =========== Event operations ===========
4149+
// =========== Tag operations ===========
41504150
//
41514151

4152-
const char* BinaryenEventGetName(BinaryenEventRef event) {
4153-
return ((Event*)event)->name.c_str();
4152+
const char* BinaryenTagGetName(BinaryenTagRef tag) {
4153+
return ((Tag*)tag)->name.c_str();
41544154
}
4155-
uint32_t BinaryenEventGetAttribute(BinaryenEventRef event) {
4156-
return ((Event*)event)->attribute;
4155+
uint32_t BinaryenTagGetAttribute(BinaryenTagRef tag) {
4156+
return ((Tag*)tag)->attribute;
41574157
}
4158-
BinaryenType BinaryenEventGetParams(BinaryenEventRef event) {
4159-
return ((Event*)event)->sig.params.getID();
4158+
BinaryenType BinaryenTagGetParams(BinaryenTagRef tag) {
4159+
return ((Tag*)tag)->sig.params.getID();
41604160
}
41614161

4162-
BinaryenType BinaryenEventGetResults(BinaryenEventRef event) {
4163-
return ((Event*)event)->sig.results.getID();
4162+
BinaryenType BinaryenTagGetResults(BinaryenTagRef tag) {
4163+
return ((Tag*)tag)->sig.results.getID();
41644164
}
41654165

41664166
//
@@ -4191,10 +4191,10 @@ const char* BinaryenGlobalImportGetModule(BinaryenGlobalRef import) {
41914191
return "";
41924192
}
41934193
}
4194-
const char* BinaryenEventImportGetModule(BinaryenEventRef import) {
4195-
auto* event = (Event*)import;
4196-
if (event->imported()) {
4197-
return event->module.c_str();
4194+
const char* BinaryenTagImportGetModule(BinaryenTagRef import) {
4195+
auto* tag = (Tag*)import;
4196+
if (tag->imported()) {
4197+
return tag->module.c_str();
41984198
} else {
41994199
return "";
42004200
}
@@ -4223,10 +4223,10 @@ const char* BinaryenGlobalImportGetBase(BinaryenGlobalRef import) {
42234223
return "";
42244224
}
42254225
}
4226-
const char* BinaryenEventImportGetBase(BinaryenEventRef import) {
4227-
auto* event = (Event*)import;
4228-
if (event->imported()) {
4229-
return event->base.c_str();
4226+
const char* BinaryenTagImportGetBase(BinaryenTagRef import) {
4227+
auto* tag = (Tag*)import;
4228+
if (tag->imported()) {
4229+
return tag->base.c_str();
42304230
} else {
42314231
return "";
42324232
}

0 commit comments

Comments
 (0)