Skip to content

Can 'Host' expressions be refactored? #2593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dcodeIO opened this issue Jan 16, 2020 · 2 comments
Closed

Can 'Host' expressions be refactored? #2593

dcodeIO opened this issue Jan 16, 2020 · 2 comments

Comments

@dcodeIO
Copy link
Contributor

dcodeIO commented Jan 16, 2020

While working on the C-API I wondered whether Host expressions can be replaced. These cover memory.grow and memory.size currently, but we also have distinct kinds for memory.init, data.drop, memory.copy and memory.fill not utilizing common base classes. Looks like refactoring Host into MemoryGrow and MemorySize would make the API more straight forward?
@kripken
Copy link
Member

kripken commented Jan 17, 2020

It would probably be good to refactor that way, yeah. It might make sense to wait for the automatic code generation stuff #2414, though, since that would make this easier / take less boilerplate

@tlively
Copy link
Member

tlively commented Jan 18, 2025

These expressions have since been refactored into their own expression classes.

@tlively tlively closed this as completed Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kripken @dcodeIO @tlively