Fix infinite loop in AsmConstWalker::visitCall #2303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
approved these changes
Aug 16, 2019
test/unit/test_lld.py
Outdated
| @@ -0,0 +1,14 @@ | |||
| from scripts.test.shared import WASM_EMSCRIPTEN_FINALIZE, run_process | |||
There was a problem hiding this comment.
Would this be better named test_finalize.py?
Can you add a copyright header?
There was a problem hiding this comment.
I am just using the lld name because all the other finalize tests are under test/lld.
As for copyright header, none of the other unit test files have it.
There was a problem hiding this comment.
I would call it test_finalize. The other tests in test/lld are there because they are actually generated by lld itself. In this case you can hard-crafting the input.
kripken
approved these changes
Aug 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show an error message when the
local.getcan't be traced back to a constant in the first argument toemscripten_asm_const_*, and suggest that the user tryEM_JS.