Fix bitselect operation in C/JS APIs #2336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
approved these changes
Sep 10, 2019
tlively
reviewed
Sep 10, 2019
There was a problem hiding this comment.
Oops! Thanks for the catch. My guess is that the JS magically worked because undefined was coerced to zero which happened to be the correct value.
I think it would be good to put the bitselect functions up above the qfma functions though, just so they are all grouped together.
|
Just figured that there's actually a |
dcodeIO
added a commit
to AssemblyScript/assemblyscript
that referenced
this pull request
Sep 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #2328 the
SIMDBitselectAPI has been replaced withSIMDTernarythat now hasBitselectas one of multiple operations, which is currently not exposed, unlike the new QFMA/QFMS operations which are exposed. This PR adds it.Makes me wonder how the binaryen/kitchen-sink.js test passed, though, because it should be missing the operation id. Isn't binaryen.js being built and tested anymore? Or did I miss something? Edit: Ah, I think it worked because
Bitselect = 0, respectivelyundefined = 0.