Use TYPE_SWITCH macro for types (NFC) #2579
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds `TYPE_SWITCH` macro that makes sure the given type is converted to `enum Type::ValueType`. Using this over the regular switch-case when switch-casing over types has an advantage that when new types are added and not handled, they will generate compile time errors. This is another attempt at solving WebAssembly#2572. We have WebAssembly#2577, and while I'm OK with that, and this is just to see what other people might think. This PR is at this stage to see what people think, and I only converted a handful of switch-cases into `TYPE_SWITCH` for now for demonstration.
tlively
reviewed
Jan 8, 2020
There was a problem hiding this comment.
One footgun I am concerned about here is that it there are no checks that you're not attempting to cast a multivalue type to ValueType. It would be good to add an assertion checking this. With that change, I think this would be similar to #2577 modulo syntax. Another potential footgun is that without removing the implicit conversion operator from Type to uint32_t, it is still possible to switch on a bare type, which would not get the helpful checks from the compiler.
|
Closing in favor of #2577. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
TYPE_SWITCHmacro that makes sure the given type isconverted to
enum Type::ValueType. Using this over the regularswitch-case when switch-casing over types has an advantage that when new
types are added and not handled, they will generate compile time errors.
This is another attempt at solving #2572. We have #2577, and while I'm
OK with that, and this is just to see what other people might think.
This PR is at this stage to see what people think, and I only converted
a handful of switch-cases into
TYPE_SWITCHfor now for demonstration.