Skip to content

Remove duplicate Type:: prefixes (NFC) #2753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 12, 2020

Conversation

aheejin
Copy link
Member

@aheejin aheejin commented Apr 12, 2020

These seem to be accidentally introduced in when we enforced use of
Type:: on type names in #2434.

By the way TIL this actually compiles, and don't know why:

Type::Type::Type::Type::Type::Type::Type::Type::none

These seem to be accidentally introduced in when we enforced use of
`Type::` on type names in WebAssembly#2434.

By the way TIL this actually compiles, and don't know why:
```
Type::Type::Type::Type::Type::Type::Type::Type::none
```
@aheejin aheejin requested a review from tlively April 12, 2020 05:32
Copy link
Member

@tlively tlively left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@aheejin aheejin merged commit 69aa389 into WebAssembly:master Apr 12, 2020
@aheejin aheejin deleted the remove_duplicate_type branch April 12, 2020 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants