Skip to content

Fix DataFlowOpts leaking temporary Functions #3093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 2, 2020
Merged

Fix DataFlowOpts leaking temporary Functions #3093

merged 1 commit into from
Sep 2, 2020

Conversation

dcodeIO
Copy link
Contributor

@dcodeIO dcodeIO commented Sep 2, 2020

Fixes DataFlowOpts leaking allocated temporary functions created to precompute an expression as their body. Reusing the body afterwards is fine because expressions are arena allocated.

@dcodeIO
Copy link
Contributor Author

dcodeIO commented Sep 2, 2020

because expressions are arena allocated.

Dangerous half-knowledge, might be wrong.

kripken
kripken approved these changes Sep 2, 2020
View reviewed changes
Copy link
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm and correct about arena allocation of the body (assuming the arena is properly handled, which I believe it is).

@dcodeIO dcodeIO merged commit ef7ab77 into WebAssembly:master Sep 2, 2020
@dcodeIO dcodeIO mentioned this pull request Sep 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kripken kripken kripken approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dcodeIO @kripken