Update Pop text format to handle tuples #3116
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously Pops were printed as ({type}.pop), and if the popped type
was a tuple, something like ((i32, i64).pop) would get
printed. However, the parser didn't support pops of anything besides
single basic types.
This PR changes the text format to be (pop *) and adds support
for parsing pops of tuples of basic types. The text format change is
designed to make parsing simpler. This change is necessary for writing
Poppy IR tests that contain break or return instructions that consume
multiple values (see #3059).