Skip to content

Add float operations for isSymmetric util #3127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 15, 2020
Merged

Add float operations for isSymmetric util #3127

merged 7 commits into from
Sep 15, 2020

Conversation

MaxGraey
Copy link
Contributor

@MaxGraey MaxGraey commented Sep 13, 2020 •
edited
Loading

Implement #3126

Add float point ops to isSymmetric:

AddFloat(32|64)*
MulFloat(32|64)*
EqFloat(32|64)
NeFloat(32|64)

* - only if we know that LHS is constant and not NaN

@MaxGraey
Copy link
Contributor Author

Fuzzed:

Invocations so far:
   FuzzExec: 19538
   CompareVMs: 5253
   CheckDeterminism: 1651
   Wasm2JS: 4677
   Asyncify: 4944

ITERATION: 22930

tlively
tlively reviewed Sep 14, 2020
View reviewed changes
tlively
tlively approved these changes Sep 14, 2020
View reviewed changes
Copy link
Member

@tlively tlively left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with that final change!

@MaxGraey MaxGraey requested a review from tlively September 14, 2020 07:15
tlively
tlively approved these changes Sep 15, 2020
View reviewed changes
Copy link
Member

@tlively tlively left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tlively tlively merged commit bcc6f29 into WebAssembly:master Sep 15, 2020
@MaxGraey MaxGraey deleted the improve-is-symmetric branch September 15, 2020 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlively tlively tlively approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaxGraey @tlively