Implement v128.{load,store}{8,16,32,64}_lane instructions #3278
Conversation
These instructions are proposed in WebAssembly/simd#350. This PR implements them throughout Binaryen except in the C/JS APIs and in the fuzzer, where it leaves TODOs instead. Right now these instructions are just being implemented for prototyping so adding them to the APIs isn't critical and they aren't generally available to be fuzzed in Wasm engines.
| ret->align = align; | ||
| ret->index = index; | ||
| ret->ptr = ptr; | ||
| ret->finalize(); |
There was a problem hiding this comment.
It looks like this does not assign vec?
(I wonder if an automatic code generation tool could help in the future here... 🤔)
There was a problem hiding this comment.
Oops! Yes, it certainly would.
| @@ -1302,6 +1302,9 @@ static size_t parseMemAttributes(Element& s, | |||
| align = fallbackAlign; | |||
| while (!s[i]->isList()) { | |||
| const char* str = s[i]->c_str(); | |||
| if (strncmp(str, "align", 5) != 0 && strncmp(str, "offset", 6) != 0) { | |||
There was a problem hiding this comment.
I'm confused, what does this do?
There was a problem hiding this comment.
These instructions are the first to have a memarg (align and offset) followed by another immediate argument. This parsing routine previously expected the align and offset to be the only non-expression operands (see the loop condition), so it wasn't able to parse the new instructions correctly. This addition makes the loop bail out instead of raise an error when it encounters a non-memarg immediate argument.
There was a problem hiding this comment.
I see, thanks. Maybe a comment on the function (saying what it parses, and that it bails on anything else)?
| @@ -1302,6 +1302,9 @@ static size_t parseMemAttributes(Element& s, | |||
| align = fallbackAlign; | |||
| while (!s[i]->isList()) { | |||
| const char* str = s[i]->c_str(); | |||
| if (strncmp(str, "align", 5) != 0 && strncmp(str, "offset", 6) != 0) { | |||
There was a problem hiding this comment.
I see, thanks. Maybe a comment on the function (saying what it parses, and that it bails on anything else)?
These instructions are proposed in WebAssembly/simd#350.
This PR implements them throughout Binaryen except in the C/JS APIs and in the
fuzzer, where it leaves TODOs instead. Right now these instructions are just
being implemented for prototyping so adding them to the APIs isn't critical and
they aren't generally available to be fuzzed in Wasm engines.