Remove extra-unreachable.wast #3480
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test seems to be added in WebAssembly#2266 to test custom unreachable generation in `BinaryenIRWriter`, but given that the `fromBinary` files only contain a single `unreaachable` for the whole function, I don't think this test serves a lot of purpose. Also the custom unreachable generation logic in WebAssembly#2266 was largely replaced in WebAssembly#3110.
kripken
approved these changes
Jan 11, 2021
tlively
approved these changes
Jan 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test seems to be added in #2266 to test custom unreachable
generation in
BinaryenIRWriter, but given that thefromBinaryfilesonly contain a single
unreachablefor the whole function, I don'tthink this test serves a lot of purpose. Also the custom unreachable
generation logic in #2266 was largely replaced in #3110.