Skip to content

[Wasm Exceptions] Fix StackIR writing of nested delegates #3599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 23, 2021
Merged

[Wasm Exceptions] Fix StackIR writing of nested delegates #3599

merged 3 commits into from
Feb 23, 2021

Conversation

kripken
Copy link
Member

@kripken kripken commented Feb 23, 2021

We were missing a pop of catchIndexStack at a Delegate. It ends the scope,
so it should do that, like TryEnd does.

Found by emscripten-core/emscripten#13485 on -O2.

@kripken kripken requested a review from aheejin February 23, 2021 21:16
aheejin
aheejin approved these changes Feb 23, 2021
View reviewed changes
Copy link
Member

@aheejin aheejin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops I missed that. Thank you!

@kripken kripken merged commit 538fe22 into main Feb 23, 2021
@kripken kripken deleted the del branch February 23, 2021 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aheejin aheejin aheejin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kripken @aheejin