Remove old syntax from table and elem in parser #3753
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlively
approved these changes
Mar 30, 2021
src/wasm/wasm-s-parser.cpp
Outdated
|
|
||
| if (s[i]->isStr()) { | ||
| char c = s[i]->c_str()[0]; | ||
| if ('0' <= c && c <= '9') { |
There was a problem hiding this comment.
You can use wasm::isInteger to check for numbers here and below.
There was a problem hiding this comment.
I'm not sure if I understand the point here, wasm::isInteger seems to check that a double is actually an integer and also not infinite.
There was a problem hiding this comment.
Sorry, I misremembered the function name. I meant String::isNumber :)
There was a problem hiding this comment.
Oh nice! Thanks. Fixed now. By the way, do we parse hex numbers in general? Is there a utility for detecting and parsing hex the way it's defined and used in the spec? e.g. 0x1000_0000
We've been keeping old syntax in the text format parser although they've been removed from the parser and hardly any test case relies on them. This PR will remove old syntax support for tables and element segments and simplify the corresponding parser functions. A few test files were affected by this that are updated.
martianboy
force-pushed
the
old-syntax-table-elem
branch
from
039d683 to
35b541e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been keeping old syntax in the text format parser although they've
been removed from the parser and hardly any test case relies on them.
This PR will remove old syntax support for tables and element segments
and simplify the corresponding parser functions. A few test files were
affected by this that are updated.