[Strings] string.encode #4776
Merged
[Strings] string.encode #4776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGraey
reviewed
Jul 7, 2022
| @@ -678,6 +678,9 @@ struct CostAnalyzer : public OverriddenVisitor<CostAnalyzer, CostType> { | |||
| CostType visitStringMeasure(StringMeasure* curr) { | |||
| return 6 + visit(curr->ref); | |||
| } | |||
| CostType visitStringEncode(StringEncode* curr) { | |||
| return 6 + visit(curr->ref) + visit(curr->ptr); | |||
There was a problem hiding this comment.
I guess cost for encoding should be bigger than visitArrayCopy has. Also it should depends on format. encode_wtf16 probably will have slightly less cost than encode_wtf8
There was a problem hiding this comment.
True. I'm not sure how much it matters though, or how we can pick a better number here. "6" is just what we use for an operation that performs a loop, which we can't really predict. If we wanted to be really precise perhaps we should emit "cannot predict" here somehow. But in practice these numbers mainly matter when comparing equivalent code, and there isn't really equivalent code to StringEncode (that is, there is no other sequence that is identical to it, like say eqz(eqz(x)) == (x != 0)).
aheejin
approved these changes
Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.