[Parser] Parse standard subtype declarations #4778
Conversation
Parse type definitions with the format `(sub $super (type ...))`. Update the test to use hybrid types so that the subtypes are reflected in the test output.
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
src/wasm/wat-parser.cpp
Outdated
| } | ||
| return Ok{}; | ||
| } | ||
|
|
||
| // subtype ::= '(' 'sub' typeidx? strtype ')' | ||
| // | strtype |
There was a problem hiding this comment.
I wasn't familiar with this notation of (sub ..). Which spec is that in?
There was a problem hiding this comment.
This is how subtypes are declared in the upstream GC spec: https://github.com/WebAssembly/gc/blob/main/test/core/gc/type-subtyping.wast. Now that I'm actually looking at the examples, though, I see that I have the order slightly wrong and that the sub should be inside the type. I'll fix the ordering.
test/lit/wat-kitchen-sink.wast
Outdated
| (type $many (func (param $x i32) (param i64 f32) (param) (param $y f64) | ||
| (result anyref (ref func)))) | ||
|
|
||
| (type $s0 (struct)) | ||
| (sub (type $s0 (struct))) |
There was a problem hiding this comment.
Reading this, I'm not actually sure what "sub" does or means..?
There was a problem hiding this comment.
The reason there is no supertype here is that syntactically the supertypes are a vector, so it is allowed for there to be zero supertypes.
Parse type definitions with the format
(type $t (sub $super ...)). Update thetest to use hybrid types so that the subtypes are reflected in the test output.