[Parser] Parse rec groups #4785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
kripken
reviewed
Jul 8, 2022
src/wasm/wat-parser.cpp
Outdated
| @@ -350,9 +351,13 @@ struct ParseTypeDefsCtx { | |||
| // Parse the names of types and fields as we go. | |||
| std::vector<TypeNames> names; | |||
|
|
|||
| // The index of the type definition we are parsing. | |||
| // The index of the type definition (i.e. rec group) we are parsing. This is | |||
There was a problem hiding this comment.
Could this be rephrased as "index is the rec group index, typeIndex is the type index inside the rec group"? If so, index => recIndex maybe?
There was a problem hiding this comment.
I stopped using parseDefs for type parsing, which let me remove this useless field entirely and rename typeIndex to just index.
kripken
approved these changes
Jul 8, 2022
|
Graphite Merge Job Current status: ✅ Merged This pull request was successfully merged as part of a stack. This comment was auto-generated by Graphite. Job Reference: wHPoO07O2vDdfBC3TH7I |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.