Fix build on Emscripten tip of tree #5019
Conversation
CMakeLists.txt
Outdated
| @@ -447,6 +448,7 @@ if(EMSCRIPTEN) | |||
| else() | |||
| target_link_libraries(binaryen_js "-sEXPORT_ES6=1") | |||
| endif() | |||
| target_link_libraries(binaryen_js "-sDEFAULT_LIBRARY_FUNCS_TO_INCLUDE=[$allocateUTF8OnStack]") | |||
There was a problem hiding this comment.
you don't need the square brackets here or above.
There was a problem hiding this comment.
I tried without the square brackets, and it hits an escaping issue with the $.
There was a problem hiding this comment.
Oh, actually my local testing must have been wrong... it's still failing on CI due to escaping 😢
There was a problem hiding this comment.
I'm trying $$ now for the escaping. I have to try on CI as for some reason my local CMake behaves differently.
Is there a simpler way to fix the escaping that I'm missing perhaps?
There was a problem hiding this comment.
Looks like I've hit this problem before #4793 (comment)
There was a problem hiding this comment.
You can also use -sEXPORTED_RUNTIME_METHODS=allocateUTF8OnStack which doesn't use $-prefixing.
No description provided.