Skip to content

Fix binaryen.js tests after require() changes on emscripten #5073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix binaryen.js tests after require() changes on emscripten #5073

wants to merge 1 commit into from

Conversation

kripken
Copy link
Member

@kripken kripken commented Sep 22, 2022

See #5071

@kripken kripken mentioned this pull request Sep 22, 2022
Merged
@kripken
Copy link
Member Author

kripken commented Sep 22, 2022

Not sure if we should land this now to fix the breakage, as discussion is still ongoing on the emscripten issue... if the broken tests prevent stuff from landing maybe we should.

@kripken
Copy link
Member Author

kripken commented Sep 22, 2022

Another option is to pin the emsdk, #5077

@kripken
Copy link
Member Author

kripken commented Sep 23, 2022

We went the other way.

@kripken kripken closed this Sep 23, 2022
@kripken kripken deleted the require branch September 23, 2022 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlively tlively tlively approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kripken @tlively