Make Asyncify work with wasm64 #5105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
asyncify_wasm64
branch
from
6b4ab0a to
791eba9
Compare
kripken
reviewed
Oct 4, 2022
sbc100
force-pushed
the
asyncify_wasm64
branch
from
791eba9 to
a51dcf9
Compare
kripken
reviewed
Oct 4, 2022
| is64 = module->memories.size() && module->memories[0]->is64(); | ||
| pointerType = is64 ? Type::i64 : Type::i32; |
There was a problem hiding this comment.
Suggested change
| is64 = module->memories.size() && module->memories[0]->is64(); | |
| pointerType = is64 ? Type::i64 : Type::i32; | |
| pointerType = module->memories[0]->indexType; |
There was a problem hiding this comment.
IIRC the problem here is that module->memories might be empty. I guess asyncify should probably error out in that case? But that seems like a bigger change.
There was a problem hiding this comment.
Oh, right, sorry, my suggested diff here isn't right then. Still, using indexType might simplify things.
sbc100
force-pushed
the
asyncify_wasm64
branch
from
a51dcf9 to
56f8cec
Compare
kripken
approved these changes
Oct 4, 2022
The emscripten side is a little tricky but I've got some tests passing. Currently blocked on: emscripten-core/emscripten#17969
sbc100
force-pushed
the
asyncify_wasm64
branch
from
56f8cec to
46da9c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The emscripten side is a little tricky but I've got some tests passing. Currently blocked on:
emscripten-core/emscripten#17969