Binary format support for wasm globals #652
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Right. I was following WebAssembly/design#727, but still missing the mutability flag. The init expression is terminated by 0x0F ( Also note that the opcodes for get/set_global are probably not final yet, because of the conflict between design PRs #727 and #711. |
|
Great, thanks. I think this is all correct currently. (Looks like I misspoke earlier when I said |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is right, but not sure I read the spec correctly.
Each global has a type and a normally-emitted expression, with a 0 ending, and it must contain one expression which is popped and used as the initial value for the global. @rossberg-chromium, is that correct?