This repository was archived by the owner on Nov 3, 2021. It is now read-only.
[interpreter] Use small-step semantics #115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
gahaas
approved these changes
Oct 4, 2019
interpreter/exec/eval.ml
Outdated
| {ty = I32Type; align = 0; offset = 0l; sz = Some Memory.Pack8}); | ||
| ] | ||
|
|
||
| | MemoryCopy, I32 n :: I32 s :: I32 d :: vs' when s >= d -> |
There was a problem hiding this comment.
Nit: The text spec says dst<=src. you could change the order of the comparison here to make the implementation here match the text spec better.
gahaas
approved these changes
Oct 4, 2019
Merged
Are you planning to make the same change for |
|
@AndrewScheidecker, yeah, there were todos for redoing the table instructions, but fixing the outdated tests seems more urgent, so see #120 . |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement bulk memory operations in small-step semantics, as in spec.
Minor fixes:
Baseline is #114. See last commit for new changes.