[test] Fix table index encoding #154
Conversation
The encoding of the table index in binary-leb128.wast is incorrect with the bulk-memory extensions, see #153. I saw and fixed the issue first in the reference types proposal (see WebAssembly/reference-types#95), but apparently it also exists here.
| @@ -33,9 +33,10 @@ | |||
| "\00asm" "\01\00\00\00" | |||
| "\04\04\01" ;; Table section with 1 entry | |||
| "\70\00\00" ;; no max, minimum 0, funcref | |||
| "\09\07\01" ;; Element section with 1 entry | |||
| "\09\09\01" ;; Element section with 1 entry | |||
There was a problem hiding this comment.
Just so that we're clear: this is doing the 2nd alternative
or at least making an explicit decision about this backward-incompatible binary representation change and removing (?) corresponding tests
from my issue description, right?
Because this changes the test itself rather than the spec, it basically acknowledges that new layout is a breaking change, but we think it's fine and won't break anything in the wild?
There was a problem hiding this comment.
Since this change was already made in WebAssembly/reference-types#95, it makes sense to do the same here.
|
Just for the reference so that it doesn't get lost, there're 4 identical tests with the same problem in various places of the test suite; they should be deduplicated: (Er, it's actually 3 identical tests, because |
|
...Ping? :) |
|
@gahaas Can you take care of the duplicates mentioned above too? |
The encoding of the table index in binary-leb128.wast is incorrect with the bulk-memory extensions, see #153. I saw and fixed the issue first in the reference types proposal (see WebAssembly/reference-types#95), but apparently it also exists here.