This repository was archived by the owner on Nov 3, 2021. It is now read-only.
Add a data declaration section to break code validation dependency on data section #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewScheidecker
added a commit
to WAVM/WAVM
that referenced
this pull request
Sep 8, 2018
This uses the alternative binary serialization I proposed here: WebAssembly/bulk-memory-operations#30.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #27, this allows streaming validation of
mem.initandmem.dropby adding data declaration sections that may occur before the code section, and must be used to declare a passive data segment.I've uploaded the HTML build of the modified spec here: https://www.scheidecker.net/2018-09-07-data-declaration-section-spec/binary/modules.html#data-declaration-section
I think the
\Bdatavecand\Bdataproductions are a bit informal, so if folks like the overall direction of this change, I'd appreciate some suggestions on how to write those.