Add some missing trap cases #81
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alex spotted missing memory length
trap_if
s in string lowering, so I did a little audit and spotted a few other discrepancies:load()
/store()
already implicitly assume in some cases (records/variants) that someone "higher up" checked the whole contiguous allocation, so assert that and remove the superfluoustrap_if
s in the integer cases. Auditing callers, the "too many params/results" case was missing this check