Skip to content

Add some missing trap cases #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2022
Merged

Add some missing trap cases #81

merged 1 commit into from
Aug 4, 2022

Conversation

lukewagner
Copy link
Member

Alex spotted missing memory length trap_ifs in string lowering, so I did a little audit and spotted a few other discrepancies:

  • string lifting doesn't check the same alignment that it requires for lowering
  • load()/store() already implicitly assume in some cases (records/variants) that someone "higher up" checked the whole contiguous allocation, so assert that and remove the superfluous trap_ifs in the integer cases. Auditing callers, the "too many params/results" case was missing this check

@lukewagner lukewagner merged commit ca2851c into main Aug 4, 2022
@lukewagner lukewagner deleted the fix-traps branch August 4, 2022 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants