-
Notifications
You must be signed in to change notification settings - Fork 695
Convert operator and type names to lowercase with underscores. #122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Also me. On pure personal preference, lower_with_underscores is my favorite naming convention. But it's also good by avoiding the uncanny valley of being 1 capitalization away from two popular naming schemes. |
Runs faster too, because C. On Tue, Jun 9, 2015 at 4:55 PM, Luke Wagner [email protected]
|
Another reason: there is necessarily going to be a mapping from WebIDL signatures into wasm signatures and this mapping will (I hope!) take |
Typed arrays will still be passable to wasm, though, as mentioned here? I don't think we can avoid Uint32Arrays etc. being a name that comes up in wasm. Overall, this seems strictly worse than to follow existing web conventions, but if I am the only person that thinks that way, this pull seems to me like the least bad of all alternatives. |
@kripken Yes, that would be a separate way for wasm to operate on a real JS |
6b6402c
to
d502de8
Compare
d502de8
to
630117b
Compare
Ok, I closed #83 and #93 so that we can focus on this one approach. Do people like this? Dislike it? Some of the names here, in particular load_heap_with_offset, int32_from_float32_bits, but possibly others too, may want further renaming, but the main goal here is to get consensus on the overall style first. |
I like this. |
I agree with @kripken that I would prefer we follow existing web conventions (e.g. by using |
630117b
to
a07305b
Compare
Is there an outcome on this? |
@pizlonator is the only one I think I remember participating in the other discussions on this, that has not weighed in here with an ok. @pizlonator, thoughts? |
a07305b
to
3473fb1
Compare
3473fb1
to
34c4d45
Compare
Now updated to use dots instead of underscores when it looks natural to do so, so operators now look like int32.add and float32.mul, since reactions to this among people I've shown it to so far were all positive. |
As discussed on IRC: merging now so we can move forward and merge dependent PRs (#135, further refactoring); we can revisit naming later. |
Convert operator and type names to lowercase with underscores.
Yet another attempt to resolve #83.