Skip to content

Update the text on wasm64. #1311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2020
Merged

Update the text on wasm64. #1311

merged 1 commit into from
Feb 6, 2020

Conversation

sunfishcode
Copy link
Member

Discussions of wasm64 have settled on thinking of it as a per-memory flag,
rather than a per-module flag, so update this documentation accordingly.

Discussions of wasm64 have settled on thinking of it as a per-memory flag,
rather than a per-module flag, so update this documentation accordingly.
@aardappel
Copy link

Maybe mention something on how this would require load instructions to optionally also accept i64 args? And once that is legal, what happens when a module containing a load from one type of index gets combined with a memory from the other? Or are we getting ahead of ourselves here? :)

@sunfishcode
Copy link
Member Author

I think load argument types are implied by saying the memory uses 64-bit indices. And I think there are straightforward ways to make linking work, but I'm not trying to write a full specification here; this is just FutureFeatures.md :).

@binji
Copy link
Member

binji commented Jan 14, 2020

This lgtm, anyone opposed to merging?

@binji
Copy link
Member

binji commented Feb 6, 2020

OK, merging. I started diving into more details here.

@binji binji merged commit 1279e3a into master Feb 6, 2020
@binji binji deleted the sunfishcode-wasm64 branch February 6, 2020 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants