Skip to content

Global types can be mutable, just not when imported #830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2016
Merged

Global types can be mutable, just not when imported #830

merged 1 commit into from
Oct 21, 2016

Conversation

binji
Copy link
Member

@binji binji commented Oct 21, 2016

No description provided.

@binji binji changed the title Global types can be immutable, just not imported Global types can be immutable, just not when imported Oct 21, 2016
@jfbastien
Copy link
Member

I don't remember: why was the restriction there before?

@binji
Copy link
Member Author

binji commented Oct 21, 2016

Not sure, but this PR is just fixing a copy-paste typo that was introduced.

@binji binji changed the title Global types can be immutable, just not when imported Global types can be mutable, just not when imported Oct 21, 2016
@rossberg
Copy link
Member

rossberg commented Oct 21, 2016 •
edited
Loading

Thanks, LGTM. I suppose I introduced that when I merged the description of global definitions and global imports into the global_type thing (the restriction only applies to the latter use).

@binji binji merged commit 4a43ba9 into binary_0xd Oct 21, 2016
@binji binji deleted the 0xd-global-type-mutable branch October 21, 2016 20:47
lukewagner added a commit that referenced this pull request Oct 26, 2016
@lukewagner
Merge binary_0xd (#836)
35e5e24 
* Reorganise opcode space (#826)

* Future-proof type opcodes (#823)

* Future-proof memory instructions (#824)

* Fix order of copysign (#828)

* Global types can be mutable, just not when imported (#830)

* Naming nit: rename `flags` to `reserved` (#832)

* Bump 0xd's version to 0xd

* Make it hex
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@binji @jfbastien @rossberg