Skip to content
This repository was archived by the owner on Apr 25, 2025. It is now read-only.

Exception section position and identifier #25

Closed
eholk opened this issue Aug 14, 2017 · 2 comments
Closed

Exception section position and identifier #25

eholk opened this issue Aug 14, 2017 · 2 comments

Comments

@eholk
Copy link
Contributor

eholk commented Aug 14, 2017

The proposal does not list a section id for the exception section. Based on this change to V8, I assume this should be 13?

It looks like the exception section must come before the code section, so sections no longer come strictly in order (modulo custom sections). How precisely should we specify the location of the exception section?

@titzer
Copy link
Contributor

titzer commented Aug 16, 2017

IMO the exception section should have a well-specified order, even though it might not match the ID. Current decoders were designed with this forward-looking assumption, since they simply do something like:

if (section_code == kFirstCode) {
readFirstSection();
section_code = next_code();
}
if (section_code == kSecondCode) {
readSecondSection();
section_code = next_code();
}
...

The actual numerical values of the section codes were expected to get out of order.

@aheejin
Copy link
Member

aheejin commented Oct 20, 2019

Closed by #62 and #75.

@aheejin aheejin closed this as completed Oct 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants