This repository was archived by the owner on Apr 25, 2025. It is now read-only.
event section ID #70
Comments
|
I don't think it matters a lot, but it may look weird. I don't mind change the event section to 13. We need to change the spec text, LLVM implementation, and V8 implementation. I can take care of the first two. @mstarzinger, could you change the event section ID in V8? |
|
Yes, that is an easy change. Coincidentally it used to be 13 in V8 until a couple of days ago because I originally chose the value at random before it was specified in the proposal. I'll keep V8 updated. Easy change similar to this one: https://chromium.googlesource.com/v8/v8/+/69ab6954b12091b7252ad79d5e940a9ed4244841 |
aheejin
added a commit
to aheejin/exception-handling
that referenced
this issue
Dec 5, 2018
We decided to change the event section code from 12 to 13 in WebAssembly#70 as the new DataCount section in the bulk memory operations proposal will take the code 12 instead.
|
LLVM change: https://reviews.llvm.org/D55343 |
aheejin
added a commit
that referenced
this issue
Dec 6, 2018
We decided to change the event section code from 12 to 13 in #70 as the new DataCount section in the bulk memory operations proposal will take the code 12 instead.
joyeecheung
pushed a commit
to joyeecheung/v8
that referenced
this issue
Feb 26, 2019
This flips the section codes for the exception section (part of the exception handling proposal) and the data-count section (part of the bulk memory proposal). Also see the following discussions for the underlying motivation: WebAssembly/bulk-memory-operations#42 WebAssembly/exception-handling#70 [email protected] BUG=v8:8868 Change-Id: I9f5f524e7aec067720346a5bb8d45c7c80a4c7a2 Reviewed-on: https://chromium-review.googlesource.com/c/1478207 Reviewed-by: Ben Smith <[email protected]> Reviewed-by: Clemens Hammacher <[email protected]> Commit-Queue: Michael Starzinger <[email protected]> Cr-Commit-Position: refs/heads/master@{#59856}
ioannad
pushed a commit
to ioannad/exception-handling
that referenced
this issue
Jun 6, 2020
* Remove irrelevant comment * Support node.js as well
ioannad
pushed a commit
to ioannad/exception-handling
that referenced
this issue
Feb 23, 2021
We decided to change the event section code from 12 to 13 in WebAssembly#70 as the new DataCount section in the bulk memory operations proposal will take the code 12 instead.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The event section is currently specified as id 12. The bulk memory proposal is also going to add a new section (see WebAssembly/bulk-memory-operations#42), and will likely ship first. Should it have 12 instead so we don't have a gap in the known section ids? Or does it even matter?
The text was updated successfully, but these errors were encountered: