This repository was archived by the owner on Apr 25, 2025. It is now read-only.
Rethrow/br_on_exn traps when given nullref #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following the discussions in WebAssembly#90, it seems desirable and less error-prone to make `rethrow` and `br_on_exn` trap in case the value on top of the stack is of `nullref` type.
Closed
lars-t-hansen
approved these changes
Jan 9, 2020
backes
approved these changes
Jan 9, 2020
dschuff
approved these changes
Jan 9, 2020
Co-Authored-By: Andreas Rossberg <[email protected]>
pull bot
pushed a commit
to p-g-krish/v8
that referenced
this pull request
Mar 23, 2020
The behaviour was clarified in the spec: WebAssembly/exception-handling#97 br_on_exn (which was done in another CL) and also rethrow should trap on nullptr. This CL implements this by an explicit check in the builtin called for rethrow. [email protected] [email protected] Bug: v8:10128 Change-Id: Icb0f4e54991b3385917bf183efa825048db4cb82 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2115430 Commit-Queue: Clemens Backes <[email protected]> Reviewed-by: Jakob Kummerow <[email protected]> Cr-Commit-Position: refs/heads/master@{#66827}
ioannad
pushed a commit
to ioannad/exception-handling
that referenced
this pull request
Jun 6, 2020
Following the discussions in WebAssembly#90, it seems desirable and less error-prone to make `rethrow` and `br_on_exn` trap in case the value on top of the stack is of `nullref` type. Closes WebAssembly#90.
ioannad
pushed a commit
to ioannad/exception-handling
that referenced
this pull request
Feb 23, 2021
Following the discussions in WebAssembly#90, it seems desirable and less error-prone to make `rethrow` and `br_on_exn` trap in case the value on top of the stack is of `nullref` type. Closes WebAssembly#90.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the discussions in #90, it seems desirable and less
error-prone to make
rethrowandbr_on_exntrap in case the value ontop of the stack is of
nullreftype.Closes #90.