This repository was archived by the owner on Apr 25, 2025. It is now read-only.
Add language to MVP.md about failure modes #134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a "Failure" subsection to MVP.md briefly describing that allocations can fail, that implementations are allowed to fail however they wish up to and including terminating the host, and noting this could open DoS vectors. Instruction notes add a link to this section to warn these instructions may trap or otherwise fail. Closes out WebAssembly#122
rossberg
pushed a commit
that referenced
this pull request
Feb 24, 2021
After the spec change in #126, byte copying order is not observable.
rossberg
reviewed
Jul 25, 2023
rossberg
reviewed
Jul 25, 2023
|
I had somehow missed out on this PR. Merged it now with a few changes and merge conflicts resolved. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a "Failure" subsection to MVP.md briefly describing that
allocations can fail, that implementations are allowed to fail
however they wish up to and including terminating the host, and
noting this could open DoS vectors.
Instruction notes add a link to this section to warn these
instructions may trap or otherwise fail.
Closes out #122
Assumes that super-large arrays (over 4 GiB) are possible; if they are not meant to be this should be clarified as well.