Skip to content
This repository was archived by the owner on Aug 17, 2022. It is now read-only.

Define modules inline in the Module section instead of in the ModuleCode section #23

Merged
merged 1 commit into from
Dec 15, 2020
Merged

Define modules inline in the Module section instead of in the ModuleCode section #23

merged 1 commit into from
Dec 15, 2020

Conversation

lukewagner
Copy link
Member

As discussed in #9.

@lukewagner
Copy link
Member Author

(Also #22)

@lukewagner
Copy link
Member Author

(Also #8)

alexcrichton
alexcrichton approved these changes Dec 15, 2020
View reviewed changes
Copy link
Collaborator

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this should fully resolve and close #9 and #22, although #8 will need the other modifications to alias discussed where the sugar in the text format isn't based on identifiers but rather strings like (func $instance_name "export_name").

Looks great though!

@lukewagner
Copy link
Member Author

Ah, right, thanks.

@lukewagner lukewagner merged commit 2de9ac4 into master Dec 15, 2020
@lukewagner lukewagner deleted the fix-issue-9 branch December 15, 2020 23:26
This was referenced Dec 15, 2020
Closed
Closed
@alexcrichton alexcrichton mentioned this pull request Feb 19, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexcrichton alexcrichton alexcrichton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukewagner @alexcrichton