Skip to content
This repository was archived by the owner on Nov 3, 2021. It is now read-only.

[js-api] ToWebAssemblyValue signature change #51

Closed
Ms2ger opened this issue Jul 16, 2019 · 1 comment
Closed

[js-api] ToWebAssemblyValue signature change #51

Ms2ger opened this issue Jul 16, 2019 · 1 comment

Comments

@Ms2ger
Copy link
Contributor

Ms2ger commented Jul 16, 2019

In #8, ToWebAssemblyValue gained an additional error argument; the current spec only passes it in a single call site. It seems like it had a caller that passed LinkError at the time. Presumably all callers should pass a value here; otherwise the argument should be marked as optional.

Alternatively, the algorithm should always throw a TypeError; that's what it already throws when ToInt32 and friends fail.

@ioannad
Copy link

ioannad commented Feb 17, 2020

I also think that the 3rd (error) argument of ToWebAssemblyValue can be safely removed, since there is no LinkError to propagate anymore. If such an error propagation is needed in the future, I would also go for an optional third argument.

Ms2ger added a commit to Ms2ger/reference-types that referenced this issue Feb 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants