This repository was archived by the owner on Dec 22, 2021. It is now read-only.
Remove i64x2 <-> f64x2 conversion opcodes #178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the SIMD sync on 2020-01-14, we discussed the challenges with implementing these instructions in a performant way on 32-bit archs. And even on 64-bit arch, like x64, it requires AVX-512 for good codegen. There is consensus that because it is uncommon for such instructions to be used, and that hardware support is not widespread, we can remove these.
tlively
approved these changes
Jan 14, 2020
dtig
approved these changes
Jan 16, 2020
Honry
added a commit
to Honry/WAVM
that referenced
this pull request
Jan 17, 2020
These ops had been removed by WebAssembly/simd#178
AndrewScheidecker
pushed a commit
to WAVM/WAVM
that referenced
this pull request
Jan 17, 2020
These ops had been removed by WebAssembly/simd#178
Honry
added a commit
to Honry/simd
that referenced
this pull request
Jan 19, 2020
These ops have been removed by WebAssembly#178
dtig
pushed a commit
that referenced
this pull request
Jan 21, 2020
These ops have been removed by #178
pull bot
pushed a commit
to p-g-krish/v8
that referenced
this pull request
Jan 28, 2020
These conversion instructions were removed from the proposal in WebAssembly/simd#178. Change-Id: I212ca2f923362bf08e178f6d28cc2338cf6f5927 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2016006 Reviewed-by: Deepti Gandluri <[email protected]> Reviewed-by: Tobias Tebbi <[email protected]> Commit-Queue: Zhi An Ng <[email protected]> Cr-Commit-Position: refs/heads/master@{#66015}
kenohassler
pushed a commit
to fgsect/WAFL
that referenced
this pull request
Oct 18, 2021
These ops had been removed by WebAssembly/simd#178
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the SIMD sync on 2020-01-14, we discussed the challenges with
implementing these instructions in a performant way on 32-bit archs. And
even on 64-bit arch, like x64, it requires AVX-512 for good codegen.
There is consensus that because it is uncommon for such instructions to
be used, and that hardware support is not widespread, we can remove
these.