Skip to content
This repository was archived by the owner on Dec 22, 2021. It is now read-only.

[spectext] Add i64x2 eq,ne,lt_s,gt_s,le_s,ge_s. #455

Merged
merged 1 commit into from
Feb 9, 2021

Conversation

ngzhian
Copy link
Member

@ngzhian ngzhian commented Feb 9, 2021

Previously it was included \ishape.\virelop, but it is incorrect, as we
don't have i64x2 unsigned comparisons.

i64x2 unsigned comparisons were added in #412.

Previously it was included \ishape.\virelop, but it is incorrect, as we
don't have i64x2 unsigned comparisons.

i64x2 signed comparisons were added in WebAssembly#412.
@ngzhian ngzhian force-pushed the i64x2-cmp_s-spectext branch from 7f3fde9 to cbd776e Compare February 9, 2021 01:56
Copy link
Member

@rossberg rossberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh dear, the arbitrariness in the instruction matrix is starting to drive me insane...

@rossberg
Copy link
Member

rossberg commented Feb 9, 2021

Hm, I wonder if some of the irregularity wouldn't be more readable with grammar side conditions that blacklist the exceptions, instead of listing all allowed cases.

@ngzhian
Copy link
Member Author

ngzhian commented Feb 9, 2021

Oh dear, the arbitrariness in the instruction matrix is starting to drive me insane...

Yea, the lowerings for i64x2 unsigned comparisons is not good enough to meet acceptance criteria, and is only better on hardware that isn't widely available yet.

Hm, I wonder if some of the irregularity wouldn't be more readable with grammar side conditions that blacklist the exceptions, instead of listing all allowed cases.

I can try to come up with some restrictions on the grammar, not sure how I would phrase it. Let me finish adding all the instructions to syntax then we can explore this, I'll file a TODO on myself.

@ngzhian ngzhian merged commit 7a8190f into WebAssembly:master Feb 9, 2021
@ngzhian ngzhian deleted the i64x2-cmp_s-spectext branch February 9, 2021 18:34
@ngzhian ngzhian added the spectext changes to spec text label Feb 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
spectext changes to spec text
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants