Fix a copy+paste error in a test name, and add a new test for symbol names #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunfishcode
force-pushed
the
test-function-names
branch
from
5af5866 to
c5226c9
Compare
|
lgtm |
sunfishcode
force-pushed
the
test-function-names
branch
from
c5226c9 to
1c921fe
Compare
sunfishcode
force-pushed
the
test-function-names
branch
from
1c921fe to
ae3cb0f
Compare
|
Rebased and trimmed tests that contain characters which are no longer accepted. |
|
Merging with lgtm (from a while ago) above, and because I believe this is uncontroversial. |
sunfishcode
added a commit
that referenced
this pull request
Nov 5, 2015
Fix a copy+paste error in a test name, and add a new test for symbol names
Connicpu
pushed a commit
to Connicpu/wasm-spec
that referenced
this pull request
May 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by WebAssembly/design#415 here is a PR that fixes the test name in question, and adds a new test for symbol name handling.
This tests a bunch of interesting names, but one thing it doesn't test is for newline characters embedded in names. That doesn't presently appear to with in the spec interpreter; I'll file a separate bug.