Disallow control characters in literals #143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossberg
changed the title
| @@ -88,7 +88,7 @@ let letter = ['a'-'z''A'-'Z'] | |||
| let symbol = ['+''-''*''/''\\''^''~''=''<''>''!''?''@''#''$''%''&''|'':''`''.'] | |||
| let tick = '\'' | |||
| let escape = ['n''t''\\''\'''\"'] | |||
| let character = [^'"''\\''\n'] | '\\'escape | '\\'hexdigit hexdigit | |||
| let character = [^'"''\\''\x00'-'\x1f'] | '\\'escape | '\\'hexdigit hexdigit | |||
There was a problem hiding this comment.
This (an below) should also exclude \x7f, the DEL character.
|
sgtm. Is it possible to write a test confirming that control characters are rejected? |
|
For the record, I think we'll want something slightly different as I mention in #142 (comment) This change shouldn't be blocked on it, though. |
Difficult. We don't have any infrastructure for testing syntax errors, which could only work outside the script language. Not sure it's worth the effort either. |
|
Addressed comment, PTAL. |
|
lgtm |
rossberg
added a commit
that referenced
this pull request
Oct 20, 2015
Disallow control characters in literals
Connicpu
pushed a commit
to Connicpu/wasm-spec
that referenced
this pull request
Jun 7, 2020
Fixes WebAssembly#142. A mismatched `DataCount` is malformed, not a validation error.
ngzhian
pushed a commit
to ngzhian/spec
that referenced
this pull request
Nov 4, 2021
It's not the same as the proposed specification document.
dhil
pushed a commit
to dhil/webassembly-spec
that referenced
this pull request
Mar 2, 2023
…mbly#143) * formal spec overview for the 3rd exception handling proposal This adds a condensed version of the current core formal spec, and some examples of reductions according to this spec. These files were added to aid in discussions when finalising spec details. After 260 PR comments and suggestions co-authors are: Co-authored-by: Andreas Rossberg <[email protected]> Co-authored-by: Heejin Ahn <[email protected]> Co-authored-by: Ross Tate <[email protected]>
dhil
pushed a commit
to dhil/webassembly-spec
that referenced
this pull request
Mar 2, 2023
This is not the suggestion given in that last review of WebAssembly#143: https://github.com/WebAssembly/exception-handling/pull/143/files#r759907998 but a potential fix of the issue raised there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #142.