Obfuscating Loop1 #181
Closed
Obfuscating Loop1 #181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seemed to have problems before so I might have to go and fix them :) |
ml-proto/test/labels.wast
Outdated
There was a problem hiding this comment.
This is doubling $i on each iteration, so the expected result would be something like 2^8, no?
There was a problem hiding this comment.
Ah, sorry, nevermind, I misread the break condition.
|
LGTM |
|
What would you think about just adding the new more complex loop as a new test, rather than replacing the existing test? I think there's value in both. |
|
Done, I added a loop3 then |
The loop1 method is too simple for LLVM, which then makes it return just 5. Though this proves that the code is correct, we probably want to have the code generation all the same. This patch makes a loop3 method based on loop1 so that the code ais bit different but at least the compiler can no longer optimize it all away. We've left loop1 to show the difference in compiler technologies
|
let me do this again... |
ngzhian
pushed a commit
to ngzhian/spec
that referenced
this pull request
Nov 4, 2021
- Fix mistake tests in simd_load.wast - Missing lane index should be malformed - Test more values of lane index
ngzhian
pushed a commit
to ngzhian/spec
that referenced
this pull request
Nov 4, 2021
[test] Fix issue WebAssembly#181
dhil
pushed a commit
to dhil/webassembly-spec
that referenced
this pull request
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The loop1 method is too simple for LLVM, which then makes it return just 5.
Though this proves that the code is correct, we probably want to have the
code generation all the same.
This patch makes the code a bit different but at least the compiler can no
longer optimize it all away.