Make grow_memory and return pages, and replace memory_size with current_memory

[rossberg]

To match WebAssembly/design#629 and WebAssembly/design#648.

[lukewagner]

lgtm, yes, we should update/add memory_size too

[rossberg]

Okay, I added memory_size to this PR, PTAL.

[lukewagner]

lgtm. One question I just remembered, and the reason I didn't simply throw in the memory_size update with design/#629, is that "size" doesn't sound quite right if the returned unit is pages. That could be a separate issue, though.

[rossberg]

Agreed. current_memory perhaps?

On 7 April 2016 at 17:34, Luke Wagner [email protected] wrote:

lgtm. One question I just remembered, and the reason I didn't simply throw
in the memory_size update with design/#629
WebAssembly/design#629, is that "size" doesn't
sound quite right if the returned unit is pages. That could be a separate
issue, though.

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#273 (comment)

[lukewagner]

Yes, that has a nice symmetry with grow_memory.

[rossberg]

Okay, updated with a rename memory_size -> current_memory. Corresponding design PR is WebAssembly/design#648. PTAL

[lukewagner]

Great, lgtm (assuming no objections to design PR).

[rossberg]

Landing with LGTM and no objections