Remove near|far split and rename (Get|Set)Memory #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you update in the readme as well? Otherwise lgtm |
Merged
| @@ -86,8 +85,8 @@ and expr' = | |||
| | SetLocal of var * expr | |||
| | GetGlobal of var | |||
| | SetGlobal of var * expr | |||
There was a problem hiding this comment.
While you're here... ASTSemantics also names load_global and store_global.
|
Other than the README, lgtm. |
lukewagner
added a commit
that referenced
this pull request
Aug 27, 2015
Remove near|far split and rename (Get|Set)Memory
|
Merging based on lgtm |
|
Oh oops, I didn't see I only updated half the README.md, will update the "external syntax" now. |
littledan
pushed a commit
to littledan/spec
that referenced
this pull request
Mar 4, 2018
It's easier to read this way.
alexcrichton
pushed a commit
to alexcrichton/spec
that referenced
this pull request
Nov 19, 2019
Clarify subsections
rossberg
referenced
this pull request
in effect-handlers/wasm-spec
Feb 15, 2021
dhil
added a commit
to dhil/webassembly-spec
that referenced
this pull request
Apr 11, 2023
…trol-lwt.wast still needs to be refactored to use cont.bind+new syntax) (WebAssembly#30)
backes
pushed a commit
to backes/spec
that referenced
this pull request
Jul 12, 2023
dhil
added a commit
to dhil/webassembly-spec
that referenced
this pull request
Apr 12, 2024
rossberg
pushed a commit
that referenced
this pull request
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch moves the linear memory operations a bit closer to the design doc. It doesn't attempt to fix the type naming situation (#26) but it does:
get*toloadandset*tostore.