-
Notifications
You must be signed in to change notification settings - Fork 472
Implement block signatures #336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
What do you think about this for block signatures? |
@AndrewScheidecker, that's actually the syntax I started out with, but I backed out for 2 reasons:
I think we can always allow the more general syntax later, and keep the simple one as a short hand. |
I agree with @AndrewScheidecker on the syntax for the block signatures, and would just make the first immediate argument of the |
Use the block signature syntax implemented here: WebAssembly/spec#336
The test changes lgtm. The proposed syntax seems acceptable to me. I've updated the candidate 0xc wast file to use the syntax proposed here: https://github.com/WebAssembly/webassembly.github.io/pull/14 (though it's not hard to change if a different syntax is ultimately chosen). |
@JSStats, |
@rossberg-chromium Generic s-exp parsers have no constrain on 'headless' lists, it is very simple to parse the |
* Specify text format for SIMD * Reword description of SIMD memory instructions Co-authored-by: Ben Smith <[email protected]>
Implements WebAssembly/design#765; specifically:
(block i32 ...)
etc)if
syntax: the label is onif
now instead of the children, in order to be consistent with the signature