[spec] Use any in Global constructor
#818
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See discussion in issue #816. In the future, we'll want to store non-numeric values in a `WebAssembly.Global` object, so using `unrestricted double` is over-constrained.
rossberg
approved these changes
Jun 7, 2018
document/js-api/index.bs
Outdated
| @@ -753,11 +753,19 @@ which can be simultaneously referenced by multiple {{Instance}} objects. Each | |||
| 1. Otherwise, throw a {{TypeError}} exception. | |||
| </div> | |||
|
|
|||
| <div algorithm> | |||
| The algorithm <dfn>DefaultGlobalValue</dfn>(|valuetype|) performs the following steps: | |||
There was a problem hiding this comment.
Nit: I would probably just call this DefaultValue, since it doesn't have any dependency on globals and might potentially be useful in other contexts.
saschanaz
reviewed
Jun 8, 2018
document/js-api/index.bs
Outdated
| @@ -720,10 +720,10 @@ dictionary GlobalDescriptor { | |||
| boolean mutable = false; | |||
| }; | |||
|
|
|||
| [LegacyNamespace=WebAssembly, Constructor(GlobalDescriptor descriptor, unrestricted double value = 0), Exposed=(Window,Worker,Worklet)] | |||
| [LegacyNamespace=WebAssembly, Constructor(GlobalDescriptor descriptor, optional any value = undefined), Exposed=(Window,Worker,Worklet)] | |||
There was a problem hiding this comment.
Web IDL currently does not support undefined. How about just removing = undefined?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion in issue #816. In the future, we'll want to store
non-numeric values in a
WebAssembly.Globalobject, so usingunrestricted doubleis over-constrained.