Skip to content

Replaced explicit truncation on memory store with implicit truncation+comment #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 25, 2015
Merged

Replaced explicit truncation on memory store with implicit truncation+comment #85

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a076a10
Replaced explicit truncation with a comment about implicit truncation
AndrewScheidecker Sep 24, 2015
2312e23
Changed comment to be more explicit than "truncate"
AndrewScheidecker Sep 24, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ml-proto/src/spec/memory.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,8 @@ let load64 mem a =
Int64.logor (Int64.of_int32 (load32 mem a)) (Int64.shift_left (Int64.of_int32 (load32 mem (a+4))) 32)

let store8 mem a bits =
!mem.{a} <- Int32.to_int (Int32.logand bits (Int32.of_int 255))
(* Store the lowest 8 bits of "bits" at byte index a, discarding the rest. *)
!mem.{a} <- Int32.to_int bits

let store16 mem a bits =
store8 mem (a+0) bits;
Expand Down