-
Notifications
You must be signed in to change notification settings - Fork 473
[spec/interpreter/tests] Rename instructions #926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm w/ some minor fixes
test/core/align.wast
Outdated
) | ||
|
||
;; $8s: i32/i64.load8_s, $8u: i32/i64.load8_u, $16s: i32/i64.load16_s, $16u: i32/i64.load16_u, $32: i32.load | ||
;; $8s: i32_i64.load8_s, $8u: i32_i64.load8_u, $16s: i32_i64.load16_s, $16u: i32_i64.load16_u, $32: i32.load |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bad search/replace
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
test/core/conversions.wast
Outdated
(func (export "f64.reinterpret_i64") (param $x i64) (result f64) (f64.reinterpret/i64 (get_local $x))) | ||
(func (export "i32.reinterpret_f32") (param $x f32) (result i32) (i32.reinterpret/f32 (get_local $x))) | ||
(func (export "i64.reinterpret_f64") (param $x f64) (result i64) (i64.reinterpret/f64 (get_local $x))) | ||
(func (export "i64.extend_s_i32") (param $x i32) (result i64) (i64.extend_i32_s (local.get $x))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rename the exports too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
test/core/float_exprs.wast
Outdated
@@ -489,17 +489,17 @@ | |||
(assert_return (invoke "f32.no_approximate_sqrt_reciprocal" (f32.const 0x1.ba4c5p+13)) (f32.const 0x1.136f16p-7)) | |||
(assert_return (invoke "f32.no_approximate_sqrt_reciprocal" (f32.const 0x1.4a5be2p+104)) (f32.const 0x1.c2b5bp-53)) | |||
|
|||
;; Test that converting i32/i64 to f32/f64 and back isn't folded away. | |||
;; Test that converting i32_i64 to f32_f64 and back isn't folded away. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
:math:`\LOCALSET~x` :math:`\hex{21}` :math:`[t] \to []` :ref:`validation <valid-local.set>` :ref:`execution <exec-local.set>` | ||
:math:`\LOCALTEE~x` :math:`\hex{22}` :math:`[t] \to [t]` :ref:`validation <valid-local.tee>` :ref:`execution <exec-local.tee>` | ||
:math:`\GLOBALGET~x` :math:`\hex{23}` :math:`[] \to [t]` :ref:`validation <valid-global.get>` :ref:`execution <exec-global.get>` | ||
:math:`\GLOBALSET~x` :math:`\hex{24}` :math:`[t] \to []` :ref:`validation <valid-global.set>` :ref:`execution <exec-global.set>` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update conversions in this file too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
* Rename {get,set,tee}_{local,global} to {local,global}.{get,set,tee} * Rename anyfunc to funcref * Rename conversion operators
Implement instruction renamings from this list on #884, as decided at 2018/10/02 CG meeting.