Skip to content

[spec/interpreter/tests] Rename instructions #926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 6, 2018
Merged

[spec/interpreter/tests] Rename instructions #926

merged 4 commits into from
Dec 6, 2018

Conversation

rossberg
Copy link
Member

@rossberg rossberg commented Nov 29, 2018

Implement instruction renamings from this list on #884, as decided at 2018/10/02 CG meeting.

@rossberg rossberg requested a review from binji November 29, 2018 16:50
Copy link
Member

@binji binji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm w/ some minor fixes

)

;; $8s: i32/i64.load8_s, $8u: i32/i64.load8_u, $16s: i32/i64.load16_s, $16u: i32/i64.load16_u, $32: i32.load
;; $8s: i32_i64.load8_s, $8u: i32_i64.load8_u, $16s: i32_i64.load16_s, $16u: i32_i64.load16_u, $32: i32.load
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bad search/replace

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

(func (export "f64.reinterpret_i64") (param $x i64) (result f64) (f64.reinterpret/i64 (get_local $x)))
(func (export "i32.reinterpret_f32") (param $x f32) (result i32) (i32.reinterpret/f32 (get_local $x)))
(func (export "i64.reinterpret_f64") (param $x f64) (result i64) (i64.reinterpret/f64 (get_local $x)))
(func (export "i64.extend_s_i32") (param $x i32) (result i64) (i64.extend_i32_s (local.get $x)))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename the exports too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@@ -489,17 +489,17 @@
(assert_return (invoke "f32.no_approximate_sqrt_reciprocal" (f32.const 0x1.ba4c5p+13)) (f32.const 0x1.136f16p-7))
(assert_return (invoke "f32.no_approximate_sqrt_reciprocal" (f32.const 0x1.4a5be2p+104)) (f32.const 0x1.c2b5bp-53))

;; Test that converting i32/i64 to f32/f64 and back isn't folded away.
;; Test that converting i32_i64 to f32_f64 and back isn't folded away.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here too

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

:math:`\LOCALSET~x` :math:`\hex{21}` :math:`[t] \to []` :ref:`validation <valid-local.set>` :ref:`execution <exec-local.set>`
:math:`\LOCALTEE~x` :math:`\hex{22}` :math:`[t] \to [t]` :ref:`validation <valid-local.tee>` :ref:`execution <exec-local.tee>`
:math:`\GLOBALGET~x` :math:`\hex{23}` :math:`[] \to [t]` :ref:`validation <valid-global.get>` :ref:`execution <exec-global.get>`
:math:`\GLOBALSET~x` :math:`\hex{24}` :math:`[t] \to []` :ref:`validation <valid-global.set>` :ref:`execution <exec-global.set>`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update conversions in this file too

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@rossberg rossberg merged commit 994591e into master Dec 6, 2018
@rossberg rossberg deleted the renamings branch December 6, 2018 07:35
@satabin satabin mentioned this pull request Dec 19, 2018
4 tasks
satabin added a commit to satabin/swam that referenced this pull request Dec 19, 2018
raoxiaojia pushed a commit to WasmCert/spec that referenced this pull request Apr 29, 2025
* Rename {get,set,tee}_{local,global} to {local,global}.{get,set,tee}
* Rename anyfunc to funcref
* Rename conversion operators
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants