-
Notifications
You must be signed in to change notification settings - Fork 72
Add support for the event section #70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Linking.md
Outdated
| | | * `0 / WASM_COMDAT_DATA`, a data segment | | ||
| | | * `1 / WASM_COMDAT_FUNCTION` | | ||
| | | * `2 / WASM_COMDAT_GLOBAL` | | ||
| | | * `3 / WASM_COMDAT_EVENT` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently the LLVM CL does not implement this, but added this entry for symmetry. (WASM_COMDAT_GLOBAL
is not implemented either). And I guess COMDATA
was a typo for COMDAT
, because in LLVM they are named as COMDAT
).
Can you explain somewhere in the doc what an "event" is? |
IMO "event" is confusing, but I can't find a better name for it. Maybe "control-flow event"? |
I agree that "event" is not the right term. The usual name for this is either an effect, or more specifically, an exception. I think we can just stick to "exception". |
I think we reviewed and agreed on the term 'event' in this PR when the second proposal was written in the beginning of this year. It is meant to include possible future constructs that may be supported later. The current LLVM and V8 implementation uses this term too. The 'attribute' field of an event entry in the event section is meant to denote which kind of event it is. Currently the only possible attribute is |
This adds support for the event section and fixes a few existing typos.