Skip to content

Add support for the event section #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 8, 2018

Conversation

aheejin
Copy link
Member

@aheejin aheejin commented Nov 5, 2018

This adds support for the event section and fixes a few existing typos.

@aheejin aheejin requested review from sbc100 and dschuff November 5, 2018 11:31
Linking.md Outdated
| | | * `0 / WASM_COMDAT_DATA`, a data segment |
| | | * `1 / WASM_COMDAT_FUNCTION` |
| | | * `2 / WASM_COMDAT_GLOBAL` |
| | | * `3 / WASM_COMDAT_EVENT` |
Copy link
Member Author

@aheejin aheejin Nov 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently the LLVM CL does not implement this, but added this entry for symmetry. (WASM_COMDAT_GLOBAL is not implemented either). And I guess COMDATA was a typo for COMDAT, because in LLVM they are named as COMDAT).

@sunfishcode
Copy link
Member

Can you explain somewhere in the doc what an "event" is?

@xtuc
Copy link
Contributor

xtuc commented Nov 6, 2018

IMO "event" is confusing, but I can't find a better name for it. Maybe "control-flow event"?

@rossberg
Copy link
Member

rossberg commented Nov 6, 2018

I agree that "event" is not the right term. The usual name for this is either an effect, or more specifically, an exception. I think we can just stick to "exception".

@aheejin
Copy link
Member Author

aheejin commented Nov 6, 2018

I think we reviewed and agreed on the term 'event' in this PR when the second proposal was written in the beginning of this year. It is meant to include possible future constructs that may be supported later. The current LLVM and V8 implementation uses this term too.

The 'attribute' field of an event entry in the event section is meant to denote which kind of event it is. Currently the only possible attribute is EXCEPTION, but other values can be added later.

@aheejin aheejin merged commit d60d66c into WebAssembly:master Nov 8, 2018
@aheejin aheejin deleted the event_section branch November 8, 2018 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants